Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec_clean does not fail if it has already been run #44

Merged
merged 1 commit into from
Nov 13, 2013

Conversation

hawknewton
Copy link

I should be able to run rake spec_clean as many times as I'd like.

before:

➜  puppet-pulp  rake spec_prep
➜  puppet-pulp  rake spec_clean
➜  puppet-pulp  rake spec_clean
rake aborted!
No such file or directory - spec/fixtures/modules/pulp
/Users/hnewton/Projects/puppetlabs_spec_helper/lib/puppetlabs_spec_helper/rake_tasks.rb:90:in `block (2 levels) in <top (required)>'
/Users/hnewton/Projects/puppetlabs_spec_helper/lib/puppetlabs_spec_helper/rake_tasks.rb:89:in `each'
/Users/hnewton/Projects/puppetlabs_spec_helper/lib/puppetlabs_spec_helper/rake_tasks.rb:89:in `block in <top (required)>'
/Users/hnewton/.rvm/gems/ruby-1.9.3-p448@puppet-pulp/bin/ruby_noexec_wrapper:14:in `eval'
/Users/hnewton/.rvm/gems/ruby-1.9.3-p448@puppet-pulp/bin/ruby_noexec_wrapper:14:in `<main>'
Tasks: TOP => spec_clean
(See full trace by running task with --trace)

after:

➜  puppet-pulp  rake spec_prep
➜  puppet-pulp  rake spec_clean
➜  puppet-pulp  rake spec_clean

apenney pushed a commit that referenced this pull request Nov 13, 2013
spec_clean does not fail if it has already been run
@apenney apenney merged commit d596899 into puppetlabs:master Nov 13, 2013
@apenney
Copy link

apenney commented Nov 13, 2013

I always hated how this failed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants