spec_standalone: apply default formatting #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usually we've a .rspec file in every module: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb By moving this to the rake task we can delete the whole .rspec file. Similar to puppetlabs#446
|
@gavindidrichsen can you review this one as well? |
Merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 41.74% 41.74%
=======================================
Files 10 10
Lines 678 678
=======================================
Hits 283 283
Misses 395 395 ☔ View full report in Codecov by Sentry. |
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 9, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
jordanbreen28
added a commit
to puppetlabs/pdk-templates
that referenced
this pull request
May 28, 2024
This commit removes the .rspec.erb file from the pdk-templates, and thus the .rspec file from being managed by PDK. This was made possible due to the changes found in puppetlabs/puppetlabs_spec_helper#452. This has minimal impact on users as the file was not configurable through .sync.yml before (other than to set as unmanaged), existing modules with the .rspec will not be affected and new modules created will simply not include an .rspec file.
3 tasks
jordanbreen28
added a commit
to puppetlabs/pdk-templates
that referenced
this pull request
May 28, 2024
This commit removes the .rspec.erb file from the pdk-templates, and thus the .rspec file from being managed by PDK. This was made possible due to the changes found in puppetlabs/puppetlabs_spec_helper#452. This has minimal impact on users as the file was not configurable through .sync.yml before (other than to set as unmanaged), existing modules with the .rspec will not be affected and new modules created will simply not include an .rspec file.
|
@bastelfreak Look's like this will have to be reverted unfortunately. It's causing knock on failures within the PDK when the output is set as junit: https://github.com/puppetlabs/pdk/actions/runs/9376052167/job/25816947136#step:6:1558 It seems like we the PDK relies on this output being given in the basic form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usually we've a .rspec file in every module:
https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb
By moving this to the rake task we can delete the whole .rspec file. Similar to #446