Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocha: Allow 2.x #456

Merged
merged 1 commit into from
Jul 5, 2024
Merged

mocha: Allow 2.x #456

merged 1 commit into from
Jul 5, 2024

Conversation

bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was talk of removing mocha support altogether. Perhaps it's time to move forward with that?

@bastelfreak
Copy link
Collaborator Author

Vox Pupuli still has some modules that use mocha:

$ grep mocha ~/code/modulesync_config/modules/voxpupuli/puppet-*/.sync.yml
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-cassandra/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-corosync/.sync.yml:  mock_with: ":mocha"
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-cvmfs/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-erlang/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-filemapper/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-firewalld/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-firewalld/.sync.yml:      - gem: 'mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-nodejs/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-rabbitmq/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-redis/.sync.yml:  mock_with: ":mocha"
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-selinux/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-swap_file/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-windowsfeature/.sync.yml:  mock_with: ':mocha'
/home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-zabbix/.sync.yml:  mock_with: ':mocha'

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastelfreak thanks for this!

@jordanbreen28 jordanbreen28 merged commit a9bc3e4 into puppetlabs:main Jul 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants