Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1984) - Add forge auth to fixtures module install #473

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented Sep 13, 2024

Summary

Prior to this PR, users were unable to perform the install of modules which required forge authorization.

This change introduces the ability to now install modules behind authorization, by referencing an env variable set by the user, and appending this onto the puppet module install operation if present.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.82%. Comparing base (6e600d1) to head (f9d6633).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   41.74%   43.82%   +2.08%     
==========================================
  Files          10       10              
  Lines         678      680       +2     
==========================================
+ Hits          283      298      +15     
+ Misses        395      382      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as draft September 13, 2024 13:03
@jordanbreen28 jordanbreen28 force-pushed the feat-add_forge_api_key_fixtures branch 2 times, most recently from 73bdd5f to 493c7c5 Compare September 16, 2024 08:28
@jordanbreen28 jordanbreen28 marked this pull request as ready for review September 16, 2024 08:28
Prior to this commit, users were unable to perform the install of
modules which required forge authorization.

This change introduces the ability to know install modules behind
authorization, by referencing an env variable set by the user, and
appending this onto the `puppet module install` operation if present.
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanbreen28 jordanbreen28 merged commit a2e1384 into main Sep 16, 2024
10 checks passed
@jordanbreen28 jordanbreen28 deleted the feat-add_forge_api_key_fixtures branch September 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants