MODULES-1202 - add module_spec_helper support for 3.6 config items #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify_facts, trusted_node_data and ordering
|
cut rodjek/rspec-puppet#212 against rspec-puppet |
| @@ -24,9 +24,15 @@ def verify_contents(subject, title, expected_lines) | |||
| ## These depend on rspec-puppet #209 and #183 being released | |||
| #c.parser = 'future' if ENV['FUTURE_PARSER'] == 'yes' | |||
| #c.strict_variables = true if ENV['STRICT_VARIABLES'] == 'yes' | |||
| #c.stringify_facts = false if ENV['STRINGIFY_FACTS'] == 'no' | |||
| #c.trusted_node_data = true if ENV['TRUSTED_NODE_DATA'] == 'yes' | |||
| #c.ordering = ENV['ORDERING'] if ENV['ORDERING'] | |||
There was a problem hiding this comment.
If you could create similar PRs to rspec-puppet as #209 and comment here, that would be great. I'd rather maintain as little code in puppetlabs_spec_helper as possible if rspec-puppet makes better sense for it (which is pretty much true of all the code in PSH, but that's the eventual goal).
There was a problem hiding this comment.
Oh hey, I see rodjek/rspec-puppet#212 now :). So if you could just update the comment?
There was a problem hiding this comment.
Yeah it looks like our comments crossed in the ajax-y ether...
hunner
added a commit
that referenced
this pull request
Jul 9, 2014
MODULES-1202 - add module_spec_helper support for 3.6 config items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially extends #65 by also adding support for the "recommended and safe" 3.6 settings
trusted_node_data,ordering, andstringify_facts. The first of these is most important to me, as it introduces$factsand$trustedas reserved variable names. The former of these is a param name on a define in puppetlabs-mcollective (which now doesn't work on 3.6 with trusted_node_data=true).This will, AFAIK, need matching work in rspec-puppet. I'll see about getting to work on that.