Update Lint to default to Puppet Approved criteria

[cyberious]

No description provided.

[Iristyle]

So I don't believe that you need to clear the :lint task here, as this would be the only :lint defined at this point in time.

The reason I had to do it in my module Rakefile was because I was overriding this task. Once the ignore_paths have been set, they cannot be changed. As mentioned, only the first :lint task will be the one run by Rake, so if you wish to change ignore_paths, then you have to ensure that there is one task.

For reference, my module uses this code:

# necessary to ensure default :lint doesn't exist, else ignore_paths won't work
Rake::Task[:lint].clear

PuppetLint.configuration.relative = true
PuppetLint.configuration.disable_class_inherits_from_params_class
PuppetLint::RakeTask.new :lint do |config|
  config.ignore_paths = ['contrib/**/*.pp', 'tests/**/*.pp', 'spec/**/*.pp', 'pkg/**/*.pp']
end

[cyberious]

If notice that we are not just creating the rake task but using the PuppetLint::RakeTask class which upon import will define a lint Rake task.

[Iristyle]

Right, you've removed task :lint, and replaced it with PuppetLint::RakeTask.new(:lint), which is fine (and the same thing my example does).

My point is that there are no tasks defined prior to calling Rake::Task[:lint].clear, making that line unnecessary.

[cyberious]

require 'puppet-lint/tasks/puppet-lint' creates the task by default. Since we have to require it prior to creating the Task via PuppetLint::RakeTask.new you have to clear it.

[domcleal]

The minimum version of puppet-lint needs setting to >= 1.1.0 in the gemspec, as older versions don't have this ability IIRC.

(And if 1.1.1 comes out before this is merged, I'd suggest changing the above items and setting it to >= 1.1.1 instead.)

[cyberious]

@domcleal so as I understand it, these are fixed but not released yet and don't know when they will be released?

[domcleal]

@cyberious yep

[tphoney]

This has went quiet, it also needs a rebase.

[cyberious]

@domcleal 4 months later still no Puppet-lint 1.1.1, @tphoney rebased