(MODULES-1576) Use Puppet FileSystem abstraction for symlinks to support Windows #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
changed the title
Iristyle
force-pushed
the
fix-spec_prep-windows
branch
from
4b807d7
to
35f8c03
Compare
- FileUtils::ln_sf is equivalent to FileUtils::ln_s and FileUtils::symlink, which are unfortunately broken in Windows through at least Ruby 2.0. In Puppet we have a FileSystem class that provides a similar abstraction, but fixes all of the methods that are broken on Ruby for Windows.
Iristyle
force-pushed
the
fix-spec_prep-windows
branch
from
35f8c03
to
dc4e8ae
Compare
Iristyle
changed the title
| @@ -88,6 +88,8 @@ def revision(scm, target, ref) | |||
|
|
|||
| desc "Create the fixtures directory" | |||
| task :spec_prep do | |||
| require 'puppet/file_system' | |||
There was a problem hiding this comment.
There are other requires from within puppet elsewhere in this file, so presumably it's OK to do so here as well.
Iristyle
changed the title
Merged
|
👍 |
cyberious
added a commit
that referenced
this pull request
Dec 12, 2014
(MODULES-1576) Use Puppet FileSystem abstraction for symlinks to support Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileUtils::symlink, which are unfortunately broken in Windows through
at least Ruby 2.0. In Puppet we have a FileSystem class that
provides a similar abstraction, but fixes all of the methods that
are broken on Ruby for Windows.