Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for PureScript 0.12 #151

Merged
merged 2 commits into from
May 25, 2018
Merged

Updates for PureScript 0.12 #151

merged 2 commits into from
May 25, 2018

Conversation

garyb
Copy link
Member

@garyb garyb commented May 24, 2018

No description provided.

natefaubion and others added 2 commits May 3, 2018 21:04
@natefaubion
0.12 Updates (#147)
eaf3d06 
* Migrate Eff to Effect

* Fix tests

* Remove monoid import

* Update package.json

* Move namespace to Effect.Aff

* Move console dependency to dev
@garyb
Update dependencies and tests
a2309ad
@garyb
Copy link
Member Author

garyb commented May 24, 2018 •
edited
Loading

@natefaubion there's a very occasional error on parallel/mixed:

D:\Home\GitHub\updates-slamdata\purescript-aff\output\Effect.Aff\foreign.js:513
                throw util.fromLeft(step);
                ^

Error: Assertion failure parallel/mixed

It happened once on Travis when I opened this PR, and I got it to happen locally every few hundred runs of the test. (I didn't run all of the tests that many times, just duplicated the running of that case 100 times and then ran the suite repeatedly 😉). Any ideas?

@garyb garyb merged commit ac1fff8 into master May 25, 2018
@garyb garyb deleted the compiler/0.12 branch May 25, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyb @natefaubion