Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roles declarations to allow safe coercions #194

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add roles declarations to allow safe coercions #194

merged 1 commit into from
Dec 4, 2020

Conversation

kl0tl
Copy link
Contributor

@kl0tl kl0tl commented Sep 12, 2020

This allows terms of type Aff a and ParAff a to be coerced to type Aff b and ParAff b when Coercible a b holds, hence allowing the zero cost coerce instead of map wrap and map unwrap to introduce and eliminate newtypes under asynchronous computations for instance.

@thomashoneyman thomashoneyman changed the base branch from master to main October 6, 2020 02:50
@kl0tl kl0tl mentioned this pull request Dec 3, 2020
Merged
@JordanMartinez JordanMartinez mentioned this pull request Dec 3, 2020
Closed
@JordanMartinez
Copy link
Contributor

@kl0tl Could you rebase this branch on top of main? That should fix CI. I tried to do that myself, but got rejected when I tried to push the changes to your branch.

@thomashoneyman thomashoneyman merged commit 9f5a6fe into purescript-contrib:main Dec 4, 2020
@kl0tl
Copy link
Contributor Author

kl0tl commented Dec 5, 2020

Thank you for rebasing for me Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kl0tl @JordanMartinez @thomashoneyman