Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumeWith doesn't consume if position does not advance #201

Merged
merged 1 commit into from
Jun 20, 2022
Merged

consumeWith doesn't consume if position does not advance #201

merged 1 commit into from
Jun 20, 2022

Conversation

jamesdbrock
Copy link
Member

issue #200

This will effect parsers:

  • rest
  • string
  • takeN
  • regex
  • whiteSpace
  • skipSpaces

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@jamesdbrock jamesdbrock linked an issue Jun 15, 2022 that may be closed by this pull request
skipSpaces always commits to branch even if no spaces are consumed #200
Closed
@jamesdbrock jamesdbrock marked this pull request as ready for review June 15, 2022 09:58
@jamesdbrock
Copy link
Member Author

Is this like what you had in mind, @JordanMartinez @natefaubion ?

@JordanMartinez
Copy link
Contributor

I think so.

@jamesdbrock
consumeWith doesn't consume if position does not advance
d644b8d 
This will effect parsers:

* rest
* string
* takeN
* regex
* whiteSpace
* skipSpaces
@jamesdbrock jamesdbrock merged commit c25d545 into main Jun 20, 2022
@jamesdbrock jamesdbrock deleted the skipspaces branch June 20, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natefaubion natefaubion natefaubion approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skipSpaces always commits to branch even if no spaces are consumed
3 participants
@jamesdbrock @JordanMartinez @natefaubion