-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: make SandboxedPath internals always Abs #54
base: main
Are you sure you want to change the base?
WIP: make SandboxedPath internals always Abs #54
Conversation
…-- --censor-codes=UserDefinedWarning
…js version using NODE_MODULE_VERSION 108. This version of Node.js requires NODE_MODULE_VERSION 115. Please try re-compiling or re-installing
2b8079a
to
8352f9e
Compare
Sandboxing is only meant to guarantee that a user provided path is not escaping some absolute context, it never claimed to make the path absolute as far as I know. But I can see where you're coming from, it does make sense that unsandboxing/printing a sandboxed path would produce an absolute path, unfortunately I don't think that's entirely harmless just now - we'd need to figure out and have the windows absolute paths working correctly too. Also, since I don't think I've said it elsewhere, thanks for all the work you're putting into things all over the place! |
Description of the change
this pr is on top of #52
what is here:
SafeAppend <///>
for SandboxedPathPathy.Name.basename
Where I use it? here https://github.com/srghma/purescript-pathy-node , can move to purescript-contrib
Checklist: