Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining issues #60

Merged
merged 10 commits into from
Jul 26, 2023
Merged

Fix remaining issues #60

merged 10 commits into from
Jul 26, 2023

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

  • Updates tests to use Aff, so rather than printing something we then manually check is correct, an exception is thrown if the expected state isn't hit.
  • Fix exitH's string value
  • Add missing FFI for execSync'
  • Drop ipc on *Sync functions (error at runtime if used in this way)
  • Drop safeStdio, inline it
  • Fix fromKillSignal FFI arg order

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez changed the title fix remaining issues Fix remaining issues Jul 26, 2023
@JordanMartinez JordanMartinez merged commit 8e031fe into master Jul 26, 2023
1 check passed
@JordanMartinez JordanMartinez deleted the fix-remaining-issues branch July 26, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant