-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shields.io for badges #102
Comments
Serif font? :) |
Can we figure out the issue with the generated SVG? If we can produce one working badge, we should be able to fix them all, right? |
Yeah. I guess I could just look at the markup that shields.io produces and imitate that with little effort. Would you rather have Pursuit serve the SVG then? |
I think we should do what's simplest, as long as we don't violate any TOS for shields.io. |
I didn't see any TOS, but it does seem that shields.io intends you to be able to fiddle with things in the way we're discussing. For example:
It looks like their server uses Cairo to determine what the width and height should be, see: https://github.com/badges/shields/blob/master/badge.js. I don't really want to do the same on the Pursuit server, that feels yucky. I guess we could choose fixed values rather than measuring text width on a canvas though; the left hand side is always the same, because it's just "pursuit", and the right hand side has a fairly narrow range of possible values, so we can probably come up with an accurate enough heuristic for that. Using a redirect seems simpler, though. |
This fixes purescript#102.
I can't quite work out what it is, but the badges that pursuit currently renders just don't quite look right. Eg: http://new-pursuit.purescript.org/packages/purescript-thermite/0.8.0
The text was updated successfully, but these errors were encountered: