Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read spago.yaml files and use them to create Manifests #593

Merged
merged 4 commits into from
Mar 12, 2023
Merged

Read spago.yaml files and use them to create Manifests #593

merged 4 commits into from
Mar 12, 2023

Conversation

f-f
Copy link
Member

@f-f f-f commented Mar 11, 2023

No description provided.

@f-f f-f requested a review from thomashoneyman March 11, 2023 13:50
@f-f
Copy link
Member Author

f-f commented Mar 11, 2023 •
edited
Loading

Ha - CI fails because we run spago install, and that can't find all the modules that spago-core imports from registry-lib.
This is because install will not include packages from the workspace but only external dependencies, but spago-core (an external dependency that depends on registry-lib, which is a workspace package) needs them for building.
This is not an issue when calling spago build because the compiler just gets all the sources and can find everything.
@thomashoneyman are we good to replace spago install with spago build?

@thomashoneyman
Copy link
Member

Yea that’s fine

thomashoneyman
thomashoneyman reviewed Mar 12, 2023
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments here and there, and then I think this looks good. Glad to have explicit spago.yaml support, even if the owners / files keys aren't yet supported!

@f-f f-f mentioned this pull request Mar 12, 2023
Closed
@f-f f-f merged commit 53a120a into master Mar 12, 2023
@f-f f-f deleted the read-spago-yaml branch March 12, 2023 23:58
This was referenced Nov 6, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-f @thomashoneyman