Remove registry-foreign dependency and use the new Spago.Glob module instead. #1220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Follow up of #1210
I replaced the only remaining use of Registry.Foreign.FastGlob.match with Spago.Glob.gitignoringGlob.
After running tests i noticed, that
compileGlob
is called with paths into the .spago directory, which is ignored by a .gitignore file, which meansgitignoringGlob
never found a match.Before using a .gitignore file for pruning the search,
gitignoringGlob
now checks that none of theincludePatterns
would be excluded.gitignorePatternToMicromatch
also had a bug,foo
in a gitignore should translate to a micromatch**/foo/**
to properly match stuff likefoo/bla/blob
.Checklist:
README
P.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊