Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uiweb): adds commands feature #1282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(uiweb): adds commands feature #1282

wants to merge 2 commits into from

Conversation

Siddesh7
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Siddesh7 Siddesh7 requested a review from HarshRajat May 15, 2024 10:56
Copy link

In 'packages/uiweb/src/lib/components/chat/types/index.ts':

  1. There is a typo in the interface 'GrouInfoType'. It should be 'GroupInfoType'.
  2. The 'FetchGroupMembersResponseType' interface is missing a closing curly brace '}'.
  3. The 'GroupMembersType' interface is missing a closing curly brace '}'.
  4. The 'TYPE' object is missing a closing curly brace '}'.
  5. The 'SUBCATEGORY' object is missing a closing curly brace '}'.
  6. The 'FrameCommand' interface is missing a closing curly brace '}'.

In 'packages/uiweb/src/lib/config/constants.ts':

  1. The 'MAINET_NETWORK' object is missing a closing curly brace '}' before 'dev' property.
  2. The 'allowedNetworks' object is missing closing square brackets ']' at the end of the 'staging' array.
  3. The 'local' and 'staging' arrays in 'allowedNetworks' object are incomplete.

Apart from the mentioned issues, the code looks good.

Please make the necessary corrections mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant