-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage support #212
base: master
Are you sure you want to change the base?
Carthage support #212
Conversation
@@ -0,0 +1,2 @@ | |||
github "tonymillion/Reachability" "master" | |||
github "square/SocketRocket" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too familiar with Carthage but should this dependency be fixed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It gets fixed in the Cartfile.resolved file I think https://github.com/pivotal-ivan-rodriguez/libPusher/blob/ios-framework/Cartfile.resolved#L2
@pivotal-ivan-rodriguez: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@pivotal-ivan-rodriguez: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pivotal-ivan-rodriguez: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added Carthage support
https://github.com/Carthage/Carthage