-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Carthage info to Readme #65
Comments
Hi @emilkarl That's interesting. I've ran Our SDK supports both platforms (iOS, Mac) so it would be incorrect to specify platform just as Thanks for your feedback, I will take your thoughts into consideration. |
Mine did not create |
@emilkarl I had a similar issue, but after updating to xCode 10.0 (dangerous) I was able to get Carthage generating iOS and code signing working. Here is a good reference for anyone else dealing with app store submission issues: I was receiving: Code signing "PushNotifications.framework" failed. |
Hi @moaxaca, how did you solve the issue with App Store submission could you provide more info on this? |
@aatalyk So my issue was really around following the install instructions in the master branch of this repo. They got me up and running for development but failed the signing process. Reference image below: I eventually went back to the Carthage docs and read their installation instructions. Probably should have done that first X). Here is a reference: I simply added the correct build phase hooks, my configuration in an image below, and everything signed and submitted correctly. Hope this help! |
Add detailed information about how to build the dependency with Carthage and integrate it into the project. Fixes #65
I have updated the readme file with more detailed installation instructions, here. Thanks for flagging this issue and apologies for any inconvenience caused. |
These steps should not be left out from docs about Carthage. There also seems to be a need to specify
--platform ios
now otherwise its installed intoBuild/Mac
.https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos
The text was updated successfully, but these errors were encountered: