80% code coverage for StorIO-Common

build.gradle

@@ -64,6 +64,9 @@ ext.libraries = [
         // Libraries for tests and sample app
         junit                          : 'junit:junit:4.12',
         mockitoCore                    : 'org.mockito:mockito-core:1.10.19',
+        powerMockJUnit                 : 'org.powermock:powermock-module-junit4:1.6.2',
+        powerMockMockito               : 'org.powermock:powermock-api-mockito:1.6.2',
+
         equalsVerifier                 : 'nl.jqno.equalsverifier:equalsverifier:1.7.2',
         guava                          : 'com.google.guava:guava:18.0',
         robolectric                    : 'org.robolectric:robolectric:3.0-rc3',

storio-common/build.gradle

@@ -25,6 +25,9 @@ dependencies {
 
     testCompile libraries.junit
     testCompile libraries.mockitoCore
+    testCompile libraries.powerMockJUnit
+    testCompile libraries.powerMockMockito
+    testCompile libraries.equalsVerifier
     testCompile libraries.storIOTestCommon
 }
 
@@ -40,4 +43,5 @@ task checkstyle(type: Checkstyle) {
     classpath = files()
 }
 
+apply from: '../gradle/jacoco-android.gradle'
 apply from: '../gradle/publish-android-lib.gradle'

storio-common/src/main/java/com/pushtorefresh/storio/StorIOException.java

@@ -7,13 +7,6 @@
  */
 public class StorIOException extends RuntimeException {
 
-    /**
-     * {@inheritDoc}
-     */
-    public StorIOException() {
-        super();
-    }
-
     /**
      * {@inheritDoc}
      */

storio-common/src/main/java/com/pushtorefresh/storio/internal/ChangesBus.java

@@ -5,8 +5,6 @@
 
 import rx.Observable;
 
-import static com.pushtorefresh.storio.internal.Environment.RX_JAVA_IS_AVAILABLE;
-
 /**
  * FOR INTERNAL USAGE ONLY.
  * <p>
@@ -15,9 +13,13 @@
 public final class ChangesBus<T> {
 
     @Nullable
-    private final RxChangesBus<T> rxChangesBus = RX_JAVA_IS_AVAILABLE
-            ? new RxChangesBus<T>()
-            : null;
+    private final RxChangesBus<T> rxChangesBus;
+
+    public ChangesBus(boolean rxJavaIsInTheClassPath) {
+        rxChangesBus = rxJavaIsInTheClassPath
+                ? new RxChangesBus<T>()
+                : null;
+    }
 
     public void onNext(@NonNull T next) {
         if (rxChangesBus != null) {

storio-common/src/main/java/com/pushtorefresh/storio/internal/Checks.java

@@ -11,7 +11,7 @@
 public final class Checks {
 
     private Checks() {
-        throw new IllegalStateException("No instances please");
+        throw new IllegalStateException("No instances please.");
     }
 
     /**

storio-common/src/main/java/com/pushtorefresh/storio/internal/Environment.java

@@ -10,14 +10,14 @@ public final class Environment {
     /**
      * True if RxJava is on classpath, false otherwise
      */
-    public static final boolean RX_JAVA_IS_AVAILABLE = isRxJavaAvailable();
+    public static final boolean RX_JAVA_IS_IN_THE_CLASS_PATH = isRxJavaInTheClassPath();
 
     private Environment() {
         throw new IllegalStateException("No instances please");
     }
 
     // thanks Retrofit for that piece of code
-    private static boolean isRxJavaAvailable() {
+    private static boolean isRxJavaInTheClassPath() {
         try {
             Class.forName("rx.Observable");
             return true;
@@ -32,7 +32,7 @@ private static boolean isRxJavaAvailable() {
      * @param messagePrefix first part of exception message, for example: "Creating Observable"
      */
     public static void throwExceptionIfRxJavaIsNotAvailable(@NonNull String messagePrefix) {
-        if (!RX_JAVA_IS_AVAILABLE) {
+        if (!RX_JAVA_IS_IN_THE_CLASS_PATH) {
             throw new IllegalStateException(messagePrefix + " requires RxJava in classpath, please add it as compile dependency to the application");
         }
     }

storio-common/src/test/java/com/pushtorefresh/storio/StorIOExceptionTest.java

@@ -0,0 +1,32 @@
+package com.pushtorefresh.storio;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertSame;
+
+public class StorIOExceptionTest {
+
+    @Test
+    public void checkConstructorWithDetailMessage() {
+        StorIOException storIOException = new StorIOException("test detail message");
+        assertEquals("test detail message", storIOException.getMessage());
+    }
+
+    @Test
+    public void checkConstructorWithDetailMessageAndThrowable() {
+        Throwable testThrowable = new RuntimeException("yo");
+        StorIOException storIOException = new StorIOException("test detail message", testThrowable);
+
+        assertEquals("test detail message", storIOException.getMessage());
+        assertSame(testThrowable, storIOException.getCause());
+    }
+
+    @Test
+    public void checkConstructorWithThrowable() {
+        Throwable testThrowable = new RuntimeException("yo");
+        StorIOException storIOException = new StorIOException(testThrowable);
+
+        assertSame(testThrowable, storIOException.getCause());
+    }
+}

storio-common/src/test/java/com/pushtorefresh/storio/internal/ChangesBusTest.java

@@ -0,0 +1,60 @@
+package com.pushtorefresh.storio.internal;
+
+import org.junit.Test;
+
+import java.util.List;
+
+import rx.Observable;
+import rx.observers.TestSubscriber;
+
+import static java.util.Arrays.asList;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.fail;
+
+public class ChangesBusTest {
+
+    @Test
+    public void asObservableShouldNotReturnNullIfRxJavaInClassPath() {
+        ChangesBus<String> changesBus = new ChangesBus<String>(true);
+        assertNotNull(changesBus.asObservable());
+    }
+
+    @Test
+    public void asObservableShouldReturnNullIfRxJavaIsNotInTheClassPath() {
+        ChangesBus<String> changesBus = new ChangesBus<String>(false);
+        assertNull(changesBus.asObservable());
+    }
+
+    @Test
+    public void onNextShouldNotThrowExceptionIfRxJavaIsNotInTheClassPath() {
+        ChangesBus<String> changesBus = new ChangesBus<String>(false);
+
+        try {
+            changesBus.onNext("don't crash me bro");
+        } catch (Exception e) {
+            fail("Yo, WTF dude?");
+        }
+    }
+
+    @Test
+    public void onNextShouldSendMessagesToObserverIfRxJavaIsInTheClassPath() {
+        ChangesBus<String> changesBus = new ChangesBus<String>(true);
+
+        TestSubscriber<String> testSubscriber = new TestSubscriber<String>();
+
+        Observable<String> observable = changesBus.asObservable();
+        assertNotNull(observable);
+
+        observable.subscribe(testSubscriber);
+
+        List<String> messages = asList("My", "life", "my", "rules", "please?");
+
+        for (String message: messages) {
+            changesBus.onNext(message);
+        }
+
+        testSubscriber.assertReceivedOnNext(messages);
+        testSubscriber.assertNoTerminalEvent();
+    }
+}

storio-common/src/test/java/com/pushtorefresh/storio/internal/ChecksTest.java

@@ -1,5 +1,7 @@
 package com.pushtorefresh.storio.internal;
 
+import com.pushtorefresh.storio.test.PrivateConstructorChecker;
+
 import org.junit.Test;
 
 import static com.pushtorefresh.storio.internal.Checks.checkNotEmpty;
@@ -9,6 +11,15 @@
 
 public class ChecksTest {
 
+    @Test
+    public void constructorShouldBePrivateAndThrowException() {
+        PrivateConstructorChecker
+                .forClass(Checks.class)
+                .expectedTypeOfException(IllegalStateException.class)
+                .expectedExceptionMessage("No instances please.")
+                .check();
+    }
+
     @Test
     public void checkNotNullPositive() {
         checkNotNull(new Object(), "No exceptions please");

storio-common/src/test/java/com/pushtorefresh/storio/internal/EnvironmentTest.java

@@ -0,0 +1,67 @@
+package com.pushtorefresh.storio.internal;
+
+import com.pushtorefresh.storio.test.PrivateConstructorChecker;
+
+import org.junit.Test;
+
+import java.lang.reflect.Field;
+
+import static java.lang.reflect.Modifier.FINAL;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+public class EnvironmentTest {
+
+    @Test
+    public void constructorShouldBePrivateAndThrowException() {
+        PrivateConstructorChecker
+                .forClass(Environment.class)
+                .expectedTypeOfException(IllegalStateException.class)
+                .expectedExceptionMessage("No instances please")
+                .check();
+    }
+
+    @Test
+    public void rxJavaShouldBeInClassPath() {
+        assertTrue(Environment.RX_JAVA_IS_IN_THE_CLASS_PATH);
+    }
+
+    @Test
+    public void shouldThrowExceptionIfRxJavaIsNotInTheClassPath() throws NoSuchFieldException, IllegalAccessException {
+        Field field = Environment.class.getDeclaredField("RX_JAVA_IS_IN_THE_CLASS_PATH");
+
+        field.setAccessible(true);
+
+        // Removing FINAL modifier
+        Field modifiersFieldOfTheField = Field.class.getDeclaredField("modifiers");
+        modifiersFieldOfTheField.setAccessible(true);
+        modifiersFieldOfTheField.setInt(field, field.getModifiers() & ~FINAL);
+
+        final Object prevValue = field.get(null);
+
+        field.set(null, false); // No Environment will think that RxJava is not in the ClassPath
+
+        try {
+            Environment.throwExceptionIfRxJavaIsNotAvailable("yolo");
+            fail();
+        } catch (IllegalStateException expected) {
+            assertEquals("yolo requires RxJava in classpath," +
+                            " please add it as compile dependency to the application",
+                    expected.getMessage()
+            );
+        } finally {
+            // Return previous value of the field
+            field.set(null, prevValue);
+
+            // Restoring FINAL modifier (for better tests performance)
+            modifiersFieldOfTheField.setInt(field, field.getModifiers() & FINAL);
+        }
+    }
+
+    @Test
+    public void shouldNotThrowExceptionIfRxJavaIsInTheClassPath() {
+        // Because RxJava should be in the ClassPath for tests
+        Environment.throwExceptionIfRxJavaIsNotAvailable("no exceptions please");
+    }
+}

storio-common/src/test/java/com/pushtorefresh/storio/internal/QueriesTest.java

@@ -1,5 +1,7 @@
 package com.pushtorefresh.storio.internal;
 
+import com.pushtorefresh.storio.test.PrivateConstructorChecker;
+
 import org.junit.Test;
 
 import java.util.ArrayList;
@@ -18,6 +20,15 @@
 
 public class QueriesTest {
 
+    @Test
+    public void constructorShouldBePrivateAndThrowException() {
+        PrivateConstructorChecker
+                .forClass(Queries.class)
+                .expectedTypeOfException(IllegalStateException.class)
+                .expectedExceptionMessage("No instances please")
+                .check();
+    }
+
     //region Tests for Queries.unmodifiableNonNullListOfStrings()
 
     @SuppressWarnings("ConstantConditions")