Fix possible deadlock caused by internal synchronization in SQLiteDatabase #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it at least should solve the issue that I've reported earlier. Not sure about the notifications you mentioned earlier. Thanks! |
|
It might be worth adding some tests using https://code.google.com/p/thread-weaver/wiki/UsersGuide |
nikitin-da
added a commit
that referenced
this pull request
Aug 5, 2015
…lock Fix possible deadlock caused by internal synchronization in SQLiteDatabase
|
We can not cover this with tests properly, because implementation of But, I'll think about more multithreading tests, our integration tests use multithreading BTW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relolves #481.
At the moment,
StorIOSQLiteOperations already written in such way that they send notifications after transaction, so I just moved calls toSQLiteDatabasetransactions out of the synchronization and keep code that manages notifications as is.@nikitin-da and @tadas-subonis please take a look and comment!
deadlocksgoaway