Add to StorIO.LowLevel getter for underlying sqLiteOpenHelper #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 96.05% 96.05% +<.01%
==========================================
Files 87 87
Lines 2459 2460 +1
Branches 329 267 -62
==========================================
+ Hits 2362 2363 +1
Misses 68 68
Partials 29 29
Continue to review full report at Codecov.
|
artem-zinnatullin
requested changes
Oct 31, 2016
| @@ -329,6 +330,21 @@ | |||
| * how to use this and when transactions are committed and rolled back. | |||
| */ | |||
| public abstract void endTransaction(); | |||
|
|
|||
| /** | |||
| * Returns {@link SQLiteOpenHelper} for the direct access to underlined database. | |||
There was a problem hiding this comment.
underlined -> underlying
|
|
||
| /** | ||
| * Returns {@link SQLiteOpenHelper} for the direct access to underlined database. | ||
| * It can be used in cases when {@link StorIOSQLite} support doesn't provided. |
There was a problem hiding this comment.
when {@link StorIOSQLite} APIs are not enough. Sounds better to me :)
| * Notice: Database changes through the direct access | ||
| * to the {@link SQLiteOpenHelper} will not trigger notifications. | ||
| * If it possible you should use {@link StorIOSQLite} methods instead | ||
| * or call {@link #notifyAboutChanges(Changes)}. |
| @NonNull | ||
| @Override | ||
| public SQLiteOpenHelper sqliteOpenHelper() { | ||
| // doesn't required in design test |
There was a problem hiding this comment.
Not required in design test.
| @@ -69,6 +69,15 @@ public void nullSQLiteOpenHelper() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void lowLevelReturnsSameInstanceOfSQLiteOpenHelper() { | |||
|
@geralt-encore PTAL, please) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #704