Fixes for resolver generators #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.05% (diff: 100%)@@ master #754 diff @@
==========================================
Files 87 87
Lines 2459 2459
Methods 0 0
Messages 0 0
Branches 329 329
==========================================
Hits 2362 2362
Misses 68 68
Partials 29 29
|
nikitin-da
approved these changes
Jan 21, 2017
| @@ -116,12 +116,12 @@ private MethodSpec createMapToContentValuesMethodSpec(@NotNull final StorIOConte | |||
| for (final StorIOContentResolverColumnMeta columnMeta : storIOContentResolverTypeMeta.columns.values()) { | |||
| final boolean ignoreNull = columnMeta.storIOColumn.ignoreNull(); | |||
| if (ignoreNull) { | |||
| builder.beginControlFlow("if($L != null)", "object." + columnMeta.elementName); | |||
| builder.beginControlFlow("if (object.$L != null)", columnMeta.elementName + (columnMeta.isMethod() ? "()" : "")); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for this #749 issue.
And also I discovered error when column annotation with
ignoreNull = trueapplied on getter.Also improved some code which was using concatenation instead of formatting.