Compile testing for StorIOContentResilverAnnotationsProccesor #761
Conversation
|
Great work man! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 87 87
Lines 2460 2460
Branches 267 267
=======================================
Hits 2363 2363
Misses 68 68
Partials 29 29Continue to review full report at Codecov.
|
|
@artem-zinnatullin would you like to read this request? Or maybe we can merge it, because it is similar to sqlite part in many respects. |
| testCompile libraries.storIOContentResolver | ||
| testCompile libraries.storIOContentResolverAnnotationsProcessor | ||
| testCompile libraries.googleTestingCompile | ||
| testCompile files(getRuntimeJar()) |
There was a problem hiding this comment.
Maybe move it to libraries declaration?
There was a problem hiding this comment.
Dunno it's not really a library. I mean it doesn't have versioning so moving it to libraries won't give much profit I guess.
There was a problem hiding this comment.
well, technically it's a library, just a jar on your system. Point is to remove code duplication from build gradle, up2u though :)
There was a problem hiding this comment.
@artem-zinnatullin done :)
|
Ouch, I forgot to squash a PR 😔 |
|
That is my fault, don't blame yourself, I'll enable squash-only option in repo settings! |
|
I just got used to it as default option so didn't even check. But it's nice that that you enabled it now. |
|
Yeah, I know that feel bro, a month or so ago I've also merged PR in some of my repos without squashing because I got used to it as default option… |
No description provided.