Annotation processors in Kotlin #775

geralt-encore · 2017-03-30T17:09:55Z

Since it is possible to use Kotlin in annotation processing without adding it as a dependency to the library itself I thought that it makes sense to use the best available tool (and Kotlin is for sure better than Java). I hope you won't mind this change.
Unfortunately, not everything is smooth. I encountered into two issues so far:

AutoService doesn't work with Kotlin classes so as a workaround I extended actual processors with dummy Java classes and annotated them.
Another problem, which I haven't solved is about running tests for processors and building sample apps from IDE. It works from a console but fails with whole code full of unresolved references from IntelliJ. It would be really nice if someone could take a look at it since I haven't figured out how to fix it.

Besides these issues everything works and looks nicer than it was before in Java :D

codecov-io · 2017-03-30T17:23:01Z

Codecov Report

Merging #775 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #775   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          87       87           
  Lines        2638     2638           
  Branches      296      296           
=======================================
  Hits         2555     2555           
  Misses         50       50           
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8575ad9...b235051. Read the comment docs.

geralt-encore · 2017-03-31T07:05:11Z

Just discovered that everything works from IDE on my work laptop. Just need to figure out what is the difference between setups.

geralt-encore · 2017-03-31T13:01:44Z

Yep, the issue was in my weird Gradle configuration for Android Studio. So everything is working without any issues.

nikitin-da

Hoho looks nice! 👍 👍
just few nits

nikitin-da · 2017-04-01T21:59:05Z

build.gradle

@@ -50,6 +54,7 @@ ext.libraries = [
        // Core libraries
        supportAnnotations             : 'com.android.support:support-annotations:' + supportLibsVersion,
        rxJava                         : 'io.reactivex:rxjava:1.2.1',
+        kotlinStdLib                         : "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version",


formatting)

nikitin-da · 2017-04-01T21:59:36Z

build.gradle

@@ -67,6 +72,7 @@ ext.libraries = [
        assertJ                        : 'org.assertj:assertj-core:3.6.2',
        assertJAndroid                 : 'com.squareup.assertj:assertj-android:1.1.1',
        mockitoCore                    : 'org.mockito:mockito-core:2.7.19',
+        mockitoKotlin                  : 'com.nhaarman:mockito-kotlin:1.3.0',


Today was released 1.4.0) https://github.com/nhaarman/mockito-kotlin/releases/tag/1.4.0

nikitin-da · 2017-04-01T22:00:41Z

...n/kotlin/com/pushtorefresh/storio/common/annotations/processor/StorIOAnnotationsProcessor.kt

+
+/**
+ * Base annotation processor for StorIO.
+ *


without double empty line?

nikitin-da · 2017-04-01T22:02:09Z

...n/kotlin/com/pushtorefresh/storio/common/annotations/processor/StorIOAnnotationsProcessor.kt

+     *
+     * It will be called after Java Compiler will find lang elements annotated with annotations from [getSupportedAnnotationTypes].
+     * @param annotations set of annotations
+     *


el here and below

nikitin-da · 2017-04-01T22:02:50Z

...ions-processor-test/src/test/resources/BoxedTypesFieldsStorIOContentResolverGetResolver.java

        }

+


nikitin-da · 2017-04-01T22:04:14Z

...pushtorefresh/storio/contentresolver/annotations/processor/StorIOContentResolverProcessor.kt

+
+        return StorIOContentResolverTypeMeta(simpleName, packageName, storIOContentResolverType)
+    }
+


nikitin-da · 2017-04-01T22:07:02Z

...shtorefresh/storio/contentresolver/annotations/processor/generate/DeleteResolverGenerator.kt

+                        .addAnnotation(ANDROID_NON_NULL_ANNOTATION_CLASS_NAME)
+                        .build())
+                .addCode("""return DeleteQuery.builder()
+$INDENT.uri(${"$"}S)


formatting query builders here and below

Yeah, this formatting bothers me as well. The thing is that I don't know how to format it since it is a literal string which sounds like a good idea for this case, but this formatting...
I can change it to concatenation if you think that is' better.

Yep I agree that with concatenation it will not look pretty too =(
Up to you

You can add indentation and then apply trimIndent()

nikitin-da · 2017-04-01T22:07:41Z

.../com/pushtorefresh/storio/contentresolver/annotations/processor/generate/MappingGenerator.kt

+
+        val superclass = ClassName.get("com.pushtorefresh.storio.contentresolver", SUFFIX)
+        val superclassParametrized = ParameterizedTypeName.get(superclass, storIOSQLiteTypeClassName)
+


nikitin-da · 2017-04-01T22:08:45Z

...c/main/kotlin/com/pushtorefresh/storio/sqlite/annotations/processor/StorIOSQLiteProcessor.kt

+/**
+ * Annotation processor for StorIOSQLite.
+ *
+ * It'll process annotations to generate StorIOSQLite


place Object-Mapping on the same line

nikitin-da · 2017-04-01T22:09:17Z

...in/kotlin/com/pushtorefresh/storio/sqlite/annotations/processor/generate/MappingGenerator.kt

+
+        val superclass = ClassName.get("com.pushtorefresh.storio.sqlite", SUFFIX)
+        val superclassParametrized = ParameterizedTypeName.get(superclass, typeClassName)
+


artem-zinnatullin · 2017-04-02T21:57:07Z

niice

nikitin-da · 2017-04-03T05:37:00Z

@artem-zinnatullin PTAL please, because you have rich experience 🐕 🍲 🍴 in Kotlin

nikitin-da · 2017-04-03T11:20:48Z

storio-common-annotations-processor/build.gradle


 dependencies {
    compile libraries.intellijAnnotations
    compile libraries.autoService
    compile libraries.javaPoet
+    compile libraries.kotlinStdLib


Will it increase module methods count on 6k? =(

I don't remember the exact number of methods in Kotlin stdlib, but it doesn't matter anyway because this dependency isn't going to be in apk so dex limit won't be affected.

artem-zinnatullin

Great! Few places that use forEach could be rewritten to kotlin streams api, but I'm ok with current variant :)

artem-zinnatullin · 2017-04-02T22:02:13Z

...t/kotlin/com/pushtorefresh/storio/common/annotations/processor/introspection/JavaTypeTest.kt

+import javax.lang.model.type.TypeKind
+import javax.lang.model.type.TypeMirror
+
+class JavaTypeTest {


Next step would be converting JUnit tests to Spek :)

Actually, I wanted to try it for quite some time, so I might take a look into it :)

There are few problems with it though, but I can help with that :)

Yeah, I know about it. Tried to setup it once - spend about an hour without success and given up until the next try.

artem-zinnatullin · 2017-04-03T19:21:26Z

...shtorefresh/storio/contentresolver/annotations/processor/generate/DeleteResolverGenerator.kt

+                        .addAnnotation(ANDROID_NON_NULL_ANNOTATION_CLASS_NAME)
+                        .build())
+                .addCode("""return DeleteQuery.builder()
+$INDENT.uri(${"$"}S)


You can add indentation and then apply trimIndent()

geralt-encore · 2017-04-03T19:56:16Z

@artem-zinnatullin thanks for pointing out to trimIndent() I didn't know about it. Will make a fix right away. Could you elaborate more about Kotlin streams api? Didn't quite get what do you mean.

artem-zinnatullin · 2017-04-03T20:08:33Z

Usually instead of let's call it "imperative" iterating over collections and populating some mutable data structures you can use more "functional" approach with operators like map/flatMap and so on in order to transform one collection into another, I can't say that it definitely worth it in your cases in this PR because there are pretty complicated and optimized for performance, but usually it's possible and makes you rethink the imperatively written code into more separated pieces of data transformation

geralt-encore · 2017-04-03T20:12:50Z

Ah, I thought that you were talking about something different. Of course, I know about functional operators like map/flatMap. I think that I used forEach just for iteration cases since there weren't actual transformations.

artem-zinnatullin · 2017-04-04T00:08:39Z

Well, they are, but that's fine :)

geralt-encore added 9 commits March 30, 2017 19:55

Common annotation processor in Kotlin

8f9ffa8

Common annotation processor tests in Kotlin

4f43368

SQLite annotation processor in Kotlin

c3a77c0

java.lang -> javaTypeObject fixes

08fcb22

Reformat

45b26b7

Fix content resolver processor tests

6f2741d

Content resolver processor in Kotlin

81ec865

Fix test case

378986f

Add dummy java processors

7c3f84f

Improve some formatting

0940c53

Eliminate it overuse

a3bd986

nikitin-da requested changes Apr 1, 2017

View reviewed changes

geralt-encore added 2 commits April 2, 2017 13:56

Fix PR comments

6defe8f

More PR fixes

7a82210

nikitin-da approved these changes Apr 3, 2017

View reviewed changes

nikitin-da requested a review from artem-zinnatullin April 3, 2017 05:37

nikitin-da reviewed Apr 3, 2017

View reviewed changes

artem-zinnatullin approved these changes Apr 3, 2017

View reviewed changes

Use trimIndent for code blocks formatting

b235051

geralt-encore merged commit da7a1f5 into pushtorefresh:master Apr 3, 2017

geralt-encore deleted the kotlin branch April 3, 2017 20:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Annotation processors in Kotlin #775

Annotation processors in Kotlin #775

geralt-encore commented Mar 30, 2017 •

edited

Loading

codecov-io commented Mar 30, 2017 •

edited

Loading

geralt-encore commented Mar 31, 2017 •

edited

Loading

geralt-encore commented Mar 31, 2017

nikitin-da left a comment

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

geralt-encore Apr 2, 2017

nikitin-da Apr 3, 2017

artem-zinnatullin Apr 3, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

nikitin-da Apr 1, 2017

artem-zinnatullin commented Apr 2, 2017

nikitin-da commented Apr 3, 2017

nikitin-da Apr 3, 2017

geralt-encore Apr 3, 2017

artem-zinnatullin left a comment

artem-zinnatullin Apr 2, 2017

geralt-encore Apr 3, 2017

artem-zinnatullin Apr 3, 2017

geralt-encore Apr 3, 2017

artem-zinnatullin Apr 3, 2017

geralt-encore commented Apr 3, 2017

artem-zinnatullin commented Apr 3, 2017

geralt-encore commented Apr 3, 2017

artem-zinnatullin commented Apr 4, 2017


		return StorIOContentResolverTypeMeta(simpleName, packageName, storIOContentResolverType)
		}


		val superclass = ClassName.get("com.pushtorefresh.storio.contentresolver", SUFFIX)
		val superclassParametrized = ParameterizedTypeName.get(superclass, storIOSQLiteTypeClassName)

Annotation processors in Kotlin #775

Annotation processors in Kotlin #775

Conversation

geralt-encore commented Mar 30, 2017 • edited Loading

codecov-io commented Mar 30, 2017 • edited Loading

Codecov Report

geralt-encore commented Mar 31, 2017 • edited Loading

geralt-encore commented Mar 31, 2017

nikitin-da left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artem-zinnatullin commented Apr 2, 2017

nikitin-da commented Apr 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artem-zinnatullin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

geralt-encore commented Apr 3, 2017

artem-zinnatullin commented Apr 3, 2017

geralt-encore commented Apr 3, 2017

artem-zinnatullin commented Apr 4, 2017

geralt-encore commented Mar 30, 2017 •

edited

Loading

codecov-io commented Mar 30, 2017 •

edited

Loading

geralt-encore commented Mar 31, 2017 •

edited

Loading