Support for Kotlin properties #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 87 87
Lines 2638 2638
Branches 296 296
=======================================
Hits 2555 2555
Misses 50 50
Partials 33 33Continue to review full report at Codecov.
|
nikitin-da
reviewed
Apr 17, 2017
| if ((methodName == String.format("get%s", name.capitalize()) | ||
| || methodName == String.format("is%s", name.capitalize()) | ||
| // Special case for properties which name starts with is. | ||
| // Kotlin will generate getter with the same name instead of isIsProperty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR it is possible to annotate Kotlin properties directly utilising getters and setter instead of direct access to fields.
Also, it resolves #735 since there is no need anymore to map fields to constructor parameters.