Fix case with different classes having fields with the same names #803
Conversation
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 89 89
Lines 2727 2727
Branches 302 302
=======================================
Hits 2645 2645
Misses 50 50
Partials 32 32Continue to review full report at Codecov.
|
README.md
Outdated
| @@ -189,6 +189,7 @@ public class Tweet { | |||
| ``` | |||
|
|
|||
| -`Kotlin`: | |||
|
@artem-zinnatullin @nikitin-da how about making a release with Kotlin related changes? Seems reasonable considering the fact of its growing popularity. |
|
@geralt-encore I agree that there is huge pack of changes and Kotlin changes required to release ASAP, but it seems RxJava2 support will break compatibility again. |
|
I see your point, but I have to concerns regarding it. First, it is not really a breaking API change - it is fixing something that was initially broken, so I think that the fact that something doesn't work in a broken way, which it was never supposed to work is a good thing. Second, we have zero ideas about the timeline of RxJava 2 support =( |
|
Unfortunately we have already merged interceptors and we should roll it back from master or release it with major version( |
|
Ouch, I completely forgot about interceptors change... Then, yeah, you are totally right. |
|
@nikitin-da yes, I think we can release v2 and then v3, that's what semantic versioning is for :) |
|
Ok, let's release v2 |
|
See #806 |
No description provided.