Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated createObservable and internal #812

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Conversation

nikitin-da
Copy link
Collaborator

Closes #607

@nikitin-da nikitin-da added this to the v2.0.0 milestone Aug 5, 2017
@nikitin-da nikitin-da self-assigned this Aug 5, 2017
@codecov-io
Copy link

codecov-io commented Aug 5, 2017

Codecov Report

Merging #812 into master will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #812     +/-   ##
========================================
+ Coverage   96.99%   97.4%   +0.4%     
========================================
  Files          89      89             
  Lines        2727    2694     -33     
  Branches      302     302             
========================================
- Hits         2645    2624     -21     
+ Misses         50      38     -12     
  Partials       32      32
Impacted Files Coverage Δ
...tentresolver/operations/put/PreparedPutObject.java 100% <ø> (+3.7%) ⬆️
...erations/put/PreparedPutContentValuesIterable.java 91.66% <ø> (-0.14%) ⬇️
...entresolver/impl/DefaultStorIOContentResolver.java 92.42% <ø> (+0.99%) ⬆️
...olver/operations/delete/PreparedDeleteByQuery.java 91.66% <ø> (+3.66%) ⬆️
...orio2/sqlite/operations/put/PreparedPutObject.java 100% <ø> (ø) ⬆️
...ions/delete/PreparedDeleteCollectionOfObjects.java 100% <ø> (+2.27%) ⬆️
...ver/operations/get/PreparedGetNumberOfResults.java 100% <ø> (+3.03%) ⬆️
...olver/operations/get/PreparedGetListOfObjects.java 100% <ø> (+2.27%) ⬆️
...orio2/sqlite/operations/get/PreparedGetObject.java 98.63% <ø> (-0.02%) ⬇️
...tentresolver/operations/get/PreparedGetCursor.java 93.33% <ø> (+3.01%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3c59...ab588ad. Read the comment docs.

Copy link
Member

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nikitin-da nikitin-da merged commit c4c7aa4 into master Aug 20, 2017
@nikitin-da nikitin-da deleted the issue-519 branch August 20, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants