Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debug builds for library modules. #833

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

artem-zinnatullin
Copy link
Member

Closes #831, but doesn't solve possible Jacoco call leaks to release artifacts

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #833 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master     #833    +/-   ##
==========================================
  Coverage     97.41%   97.41%            
- Complexity        0      791   +791     
==========================================
  Files            91       91            
  Lines          2707     2707            
  Branches        305      305            
==========================================
  Hits           2637     2637            
  Misses           38       38            
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a978d97...13d8d06. Read the comment docs.

@artem-zinnatullin
Copy link
Member Author

Hah @nikitin-da! No coverage loss, faster build and only 7k log lines!

@geralt-encore geralt-encore merged commit 46ac214 into master Oct 16, 2017
@nikitin-da nikitin-da deleted the az/disable-debug-builds branch October 17, 2017 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants