Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment variable to detect publishing state. #834

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

artem-zinnatullin
Copy link
Member

Uhh damn Gradle, Travis and everything.

I wasn't able to use Gradle task graph analysis, so one way is to use env variable as I do here, another way is to always try to read release-related env variables for signing but I do find it more error prone and hard to debug in case if something will go wrong, current process will break build asap which is easier to debug

Sorry for so many PRs, but it's hard to test locally because CI has pretty different setup

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #834   +/-   ##
=========================================
  Coverage     97.41%   97.41%           
  Complexity      791      791           
=========================================
  Files            91       91           
  Lines          2707     2707           
  Branches        305      305           
=========================================
  Hits           2637     2637           
  Misses           38       38           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ac214...178f525. Read the comment docs.

@artem-zinnatullin artem-zinnatullin merged commit 3c33219 into master Oct 16, 2017
@artem-zinnatullin artem-zinnatullin deleted the az/use-env-var-for-publishing branch October 16, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants