Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do clean release build to exclude Jacoco from jar. #836

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

artem-zinnatullin
Copy link
Member

Related to discussion in #831.

# Export "PUBLISH_RELEASE=true" to initiate release process.
if [ "$PUBLISH_RELEASE" == "true" ]; then
if [ "$PUBLISH_RELEASE" != "true" ]; then
echo "Running non-release build...".
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I decided to wrap non-release build in if statement as well, otherwise it was always running repeating unnecessary build parts for publish state

@artem-zinnatullin artem-zinnatullin merged commit 46e0456 into master Oct 16, 2017
@artem-zinnatullin artem-zinnatullin deleted the az/clean-release-build branch October 16, 2017 13:05
@codecov-io
Copy link

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #836   +/-   ##
=========================================
  Coverage     97.41%   97.41%           
  Complexity      791      791           
=========================================
  Files            91       91           
  Lines          2707     2707           
  Branches        305      305           
=========================================
  Hits           2637     2637           
  Misses           38       38           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c33219...0574e55. Read the comment docs.

@artem-zinnatullin
Copy link
Member Author

Uhhh

FAILURE: Build failed with an exception.

  • What went wrong:
    Execution failed for task ':storio-common:signArchives'.

Cannot perform signing task ':storio-common:signArchives' because it has no configured signatory

Will look later :(

@artem-zinnatullin
Copy link
Member Author

Ok, so I'm not sure why it doesn't work on CI, I've configured local machine very similary and used same release scripting, and it works for me locally.

My guess is that version of gpg is incompatible with one I use on mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants