-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite optional usage to allow Flowable implementation #856
Conversation
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
============================================
+ Coverage 97.33% 97.68% +0.34%
- Complexity 799 819 +20
============================================
Files 92 97 +5
Lines 2663 2719 +56
Branches 298 299 +1
============================================
+ Hits 2592 2656 +64
+ Misses 44 35 -9
- Partials 27 28 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Now I got the idea
try { | ||
final Result value = preparedOperation.executeAsBlocking(); | ||
emitter.onNext(Optional.of(value)); | ||
emitter.onComplete(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that it has to complete here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think yes. We use this flowable only for starting emission or if have no tables/tags to observe.
Another flowable created by ChangesFilter.applyForTablesAndTags
will not complete
@@ -56,7 +56,7 @@ | |||
@WorkerThread | |||
@NonNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nullable ?
} | ||
|
||
private class RealCallInterceptor<UnwrappedResult> implements Interceptor { | ||
private class RealCallInterceptor implements Interceptor { | ||
@NonNull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nullable
I will add tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'll try to work on Maybe as soon as I can, but can't promise anything - too much stuff is going on =(
No description provided.