-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support io.reactivex.Maybe #857
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
storio-common/src/main/java/com/pushtorefresh/storio2/operations/PreparedMaybeOperation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.pushtorefresh.storio2.operations; | ||
|
|
||
| import android.support.annotation.CheckResult; | ||
| import android.support.annotation.NonNull; | ||
| import io.reactivex.Maybe; | ||
|
|
||
| /** | ||
| * Common API of prepared operations with {@link Maybe} support | ||
| * | ||
| * @param <Result> type of result | ||
| */ | ||
| public interface PreparedMaybeOperation<Result, WrappedResult, Data> extends PreparedOperation<Result, WrappedResult, Data> { | ||
|
|
||
| @NonNull | ||
| @CheckResult | ||
| Maybe<Result> asRxMaybe(); | ||
| } |
36 changes: 36 additions & 0 deletions
36
...java/com/pushtorefresh/storio2/operations/internal/MaybeOnSubscribeExecuteAsBlocking.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.pushtorefresh.storio2.operations.internal; | ||
|
|
||
| import android.support.annotation.NonNull; | ||
| import com.pushtorefresh.storio2.operations.PreparedMaybeOperation; | ||
| import io.reactivex.MaybeEmitter; | ||
| import io.reactivex.MaybeOnSubscribe; | ||
|
|
||
| /** | ||
| * Required to avoid problems with ClassLoader when RxJava is not in ClassPath | ||
| * We can not use anonymous classes from RxJava directly in StorIO, ClassLoader won't be happy :( | ||
| * <p> | ||
| * For internal usage only! | ||
| */ | ||
| public final class MaybeOnSubscribeExecuteAsBlocking<Result, WrappedResult, Data> implements MaybeOnSubscribe<Result> { | ||
|
|
||
| @NonNull | ||
| private final PreparedMaybeOperation<Result, WrappedResult, Data> preparedOperation; | ||
|
|
||
| public MaybeOnSubscribeExecuteAsBlocking(@NonNull PreparedMaybeOperation<Result, WrappedResult, Data> preparedOperation) { | ||
| this.preparedOperation = preparedOperation; | ||
| } | ||
|
|
||
| @Override | ||
| public void subscribe(MaybeEmitter<Result> emitter) throws Exception { | ||
| try { | ||
| final Result value = preparedOperation.executeAsBlocking(); | ||
| if (value != null) { | ||
| emitter.onSuccess(value); | ||
| } else { | ||
| emitter.onComplete(); | ||
| } | ||
| } catch (Exception e) { | ||
| emitter.onError(e); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
.../com/pushtorefresh/storio2/operations/internal/MaybeOnSubscribeExecuteAsBlockingTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| package com.pushtorefresh.storio2.operations.internal; | ||
|
|
||
| import com.pushtorefresh.storio2.StorIOException; | ||
| import com.pushtorefresh.storio2.operations.PreparedMaybeOperation; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import io.reactivex.Maybe; | ||
| import io.reactivex.observers.TestObserver; | ||
|
|
||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.verifyZeroInteractions; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class MaybeOnSubscribeExecuteAsBlockingTest { | ||
|
|
||
| @SuppressWarnings("CheckResult") | ||
| @Test | ||
| public void shouldExecuteAsBlockingAfterSubscription() { | ||
| //noinspection unchecked | ||
| final PreparedMaybeOperation<String, String, String> preparedOperation = mock(PreparedMaybeOperation.class); | ||
| String expectedResult = "test"; | ||
| when(preparedOperation.executeAsBlocking()).thenReturn(expectedResult); | ||
|
|
||
| TestObserver<String> testObserver = new TestObserver<String>(); | ||
|
|
||
| verifyZeroInteractions(preparedOperation); | ||
|
|
||
| Maybe<String> maybe = Maybe.create(new MaybeOnSubscribeExecuteAsBlocking<String, String, String>(preparedOperation)); | ||
|
|
||
| verifyZeroInteractions(preparedOperation); | ||
|
|
||
| maybe.subscribe(testObserver); | ||
|
|
||
| testObserver.assertValue(expectedResult); | ||
| testObserver.assertNoErrors(); | ||
| testObserver.assertComplete(); | ||
|
|
||
| verify(preparedOperation).executeAsBlocking(); | ||
| } | ||
|
|
||
| @SuppressWarnings("CheckResult") | ||
| @Test | ||
| public void shouldCompleteIfNullOccurred() { | ||
| //noinspection unchecked | ||
| final PreparedMaybeOperation<String, String, String> preparedOperation = mock(PreparedMaybeOperation.class); | ||
| when(preparedOperation.executeAsBlocking()).thenReturn(null); | ||
|
|
||
| TestObserver<String> testObserver = new TestObserver<String>(); | ||
|
|
||
| verifyZeroInteractions(preparedOperation); | ||
|
|
||
| Maybe<String> maybe = Maybe.create(new MaybeOnSubscribeExecuteAsBlocking<String, String, String>(preparedOperation)); | ||
|
|
||
| verifyZeroInteractions(preparedOperation); | ||
|
|
||
| maybe.subscribe(testObserver); | ||
|
|
||
| testObserver.assertNoErrors(); | ||
| testObserver.assertComplete(); | ||
|
|
||
| verify(preparedOperation).executeAsBlocking(); | ||
| } | ||
|
|
||
| @SuppressWarnings("CheckResult") | ||
| @Test | ||
| public void shouldCallOnErrorIfExceptionOccurred() { | ||
| //noinspection unchecked | ||
| final PreparedMaybeOperation<Object, Object, Object> preparedOperation = mock(PreparedMaybeOperation.class); | ||
|
|
||
| StorIOException expectedException = new StorIOException("test exception"); | ||
|
|
||
| when(preparedOperation.executeAsBlocking()).thenThrow(expectedException); | ||
|
|
||
| TestObserver<Object> testObserver = new TestObserver<Object>(); | ||
|
|
||
| Maybe<Object> maybe = Maybe.create(new MaybeOnSubscribeExecuteAsBlocking<Object, Object, Object>(preparedOperation)); | ||
|
|
||
| verifyZeroInteractions(preparedOperation); | ||
|
|
||
| maybe.subscribe(testObserver); | ||
|
|
||
| testObserver.assertError(expectedException); | ||
| testObserver.assertNotComplete(); | ||
|
|
||
| verify(preparedOperation).executeAsBlocking(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nullability