This repository has been archived by the owner on May 13, 2021. It is now read-only.
V0.5.0 - Enable platform extensibility in ManifoldJS #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENSE.txt, package.json, README.md
…ndencies as well as then main module and to support both promises and callbacks
…dateManifest from loader module
…name--it's now determined by downloading the package.json from the specified source
…t present in the project
| var deferred = Q.defer(); | ||
| getW3cManifest(siteUrl, program.manifest, function (err, manifestInfo) { | ||
| if (err) { | ||
| return deferred.reject(err); |
There was a problem hiding this comment.
It would be great in 6.0 to move to standard promises, or is there some advantage to using Q?.
There was a problem hiding this comment.
Thank you for taking the time to provide all this feedback. There was no time to include more changes for the current release, but we will take this into consideration for the next update.
This release involved significant re-architecture in a limited time and there are a number of things that had to be postponed. Regarding the use of standard promises, this is something that we considered and need to investigate.
f2bo
added a commit
that referenced
this pull request
Feb 23, 2016
V0.5.0 - Enable platform extensibility in ManifoldJS
This was referenced Feb 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable platform extensibility in ManifoldJS and allow users to implement additional platforms that can be added to the tool (Closes #205)