Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests, LICENSE, & CONTRIBUTORS.txt in the source dist #43

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Include tests, LICENSE, & CONTRIBUTORS.txt in the source dist #43

merged 1 commit into from
Oct 19, 2018

Conversation

jdufresne
Copy link
Contributor

Helps comply with own license:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

There is no need to explicitly include pyprof2calltree.py, that is
handled automatically by setuptools as it is listed as py_modules.

Allows running the tests from the source distribution.

@pwaller
Copy link
Owner

pwaller commented Oct 10, 2018

I'm holding off on this one: Travis says it is green, but GitHub does not. I consider this good to merge, however, I am having trouble with Travis which is a having significant negative impact on another private repository. I also pointed them at this one, where it seems the event has gone missing, in case there is something to be learned from it.

So I'll merge this once they get back to me.

Helps comply with own license:

> The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

There is no need to explicitly include pyprof2calltree.py, that is
handled automatically by setuptools as it is listed as py_modules.

Allows running the tests from the source distribution.
@jdufresne
Copy link
Contributor Author

Hmm. Not sure why that happened.

I rebased the commit so Travis would rerun. Now, both GitHub & Travis are green.

@pwaller
Copy link
Owner

pwaller commented Oct 19, 2018

Thanks, sorry I dropped this, I was waiting for github to respond and they took a while!

@pwaller pwaller merged commit 2acc6f6 into pwaller:master Oct 19, 2018
@jdufresne jdufresne deleted the manifest branch April 19, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants