fixed it so that pwn can sync extra credit assignments to pwn.college… #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added an extra_credit_max field for the calcuation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug / adding a feature to support pwn.college assignments that are extra credit.
The Canvas sync was using only a % to update the canvas grade, which will automatically take into account the possible points. However, for extra credit assignments, the possible points are zero. As a result, nothing was getting transferred to Canvas.
I added code that will check if the possible points are 0 and the field extra_credit_max is > 0 then in course.xml for the assessment, then it will calculate the points to post to Canvas using the extra_credit_max.
I ran tests against my dev instance using ASU's beta account for Canvas.