code.misc>new: add msg to show rate of process in convert command

pwnfan · May 19, 2023 · 112eeda · 112eeda
1 parent 5199240
commit 112eeda
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -214,8 +214,8 @@ We welcome you to join the development of tagmark. Please see [contributing docu
 ## TODO
 
 - [x] lib.data: skip dumping some tagmark item according to user input
-- [ ] Tagmark.get_github_repo_infos add condition filter
-- [ ] add msg to show rate of process in `convert` command becuase it may be slow when there are a plenty of github repo urls
+- [x] Tagmark.get_github_repo_infos add condition filter
+- [x] add msg to show rate of process in `convert` command becuase it may be slow when there are a plenty of github repo urls
 - [ ] lib.data: add github repo licence info into TagmarkItem
 - [ ] validate url availability and set TagmarkItem.valid according to the result
 

diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -12,6 +12,7 @@ requests = "^2.28.2"
 structlog = "^23.1.0"
 click = "^8.1.3"
 python-dotenv = "^1.0.0"
+tqdm = "^4.65.0"
 
 
 [tool.poetry.group.test.dependencies]

diff --git a/tagmark/core/data.py b/tagmark/core/data.py
@@ -3,6 +3,8 @@
 from pathlib import Path
 from typing import Iterable, NewType
 
+from tqdm import tqdm
+
 from tagmark.core.github import (
     GithubApiLimitReachedError,
     GithubRepoInfo,
@@ -157,7 +159,10 @@ def get_github_repo_infos(
             raise GithubApiLimitReachedError(
                 f"API limit reached, needs {self.count_github_url}, remaining {_github_api_remaining}"
             )
-        for _tagmark_item in self.tagmark_items:
+        for _tagmark_item in tqdm(
+            iterable=self.tagmark_items,
+            desc="retrieving Github repository information",
+        ):
             if not _tagmark_item.is_github_url:
                 continue
             elif (

diff --git a/tests/core/test_data.py b/tests/core/test_data.py
@@ -118,7 +118,7 @@ def test_get_github_repo_infos(
         assert github_repo_info.count_tag is None  # TODO
         assert github_repo_info.count_release is None  # TODO
         assert github_repo_info.count_conributor is None  # TODO
-        
+
         github_repo_info: GithubRepoInfo = self.tagit.tagmark_items[-1].github_repo_info
         assert not github_repo_info