-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colors based on Issue / PR state #637
Conversation
EDIT: Previews of |
I have the colors wrong. The merge should be purple and there should be red if closed. Might need to pull in some more in query |
Hi @p5quared, Thanks for the review! I ended up adding richer set of symbols to match the github interface a bit more. Think it looks way better now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olgtm, you can merge if you agree with the comment.
On a side note, I suggest we default to squash and merge to keep the master git history clean, either this or we make the effort of cleaning up the commits before merging which is a bit overkill for a small project like this.
Co-authored-by: Guiom <guillaume@glagrange.eu>
Describe what this PR does / why we need it
Using the state, isDraft, stateReason fields from the graphql API to determine the icon and color of the PR or Issue. This should be consistent with the github interface.
This works for
:Octo issue / pr list / search
and:Octo search
Does this pull request fix one issue?
Related to #485
Describe how you did it
Describe how to verify it
Run any of the affected commands and see that the icons will be colored based on the state of the PR or Issue.
Special notes for reviews
This only effects telescope picker
Checklist