Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feols: Jit compile collinearity detection in _find_collinear_variables #466

Closed
s3alfisc opened this issue May 30, 2024 · 0 comments · Fixed by #579
Closed

Feols: Jit compile collinearity detection in _find_collinear_variables #466

s3alfisc opened this issue May 30, 2024 · 0 comments · Fixed by #579
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@s3alfisc
Copy link
Member

Context

The fuction _find_collinear_variables checks for multicollinearity using a cholesky decomposition. With many variables, it might become quite slow. One workaround is to jit compile it with numba.

To do

Jit-compile _find_collinar_variables.
@s3alfisc s3alfisc converted this from a draft issue May 30, 2024
@s3alfisc s3alfisc added enhancement New feature or request good first issue Good for newcomers labels May 30, 2024
@s3alfisc s3alfisc changed the title Jit compile collinearity detection in _find_collinear_variables Feols: Jit compile collinearity detection in _find_collinear_variables May 30, 2024
s3alfisc added a commit that referenced this issue Aug 11, 2024
@s3alfisc
jit compile multicollinearity detection #466
c145753
@s3alfisc s3alfisc mentioned this issue Aug 11, 2024
Merged
s3alfisc added a commit that referenced this issue Aug 11, 2024
@s3alfisc
jit compile multicollinearity detection #466 (#579)
1e221ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Feols Enhancements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jit compile multicollinearity detection #466 py-econometrics/pyfixest
1 participant
@s3alfisc