Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align demeaning convergence criterion with pyhdfe #187

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified pyfixest/__pycache__/demean.cpython-310.pyc
Binary file not shown.
Binary file modified pyfixest/__pycache__/estimation.cpython-310.pyc
Binary file not shown.
Binary file modified pyfixest/__pycache__/feols.cpython-310.pyc
Binary file not shown.
Binary file modified pyfixest/__pycache__/fepois.cpython-310.pyc
Binary file not shown.
Binary file modified pyfixest/__pycache__/utils.cpython-310.pyc
Binary file not shown.
3 changes: 1 addition & 2 deletions pyfixest/demean.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ def demean_model(
@nb.njit
def _sad_converged(a, b, tol):
for i in range(a.size):
tol -= np.abs(a[i] - b[i])
if tol < 0:
if np.abs(a[i] - b[i]) >= tol:
return False
return True

Expand Down
Binary file modified tests/__pycache__/test_ses.cpython-310-pytest-7.3.1.pyc
Binary file not shown.
Binary file modified tests/__pycache__/test_vs_fixest.cpython-310-pytest-7.3.1.pyc
Binary file not shown.
Loading