Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug in Resid / Predict when Model is Emtpy #597

Merged
merged 11 commits into from
Aug 31, 2024
Merged

Fix Bug in Resid / Predict when Model is Emtpy #597

merged 11 commits into from
Aug 31, 2024

Conversation

s3alfisc
Copy link
Member

@s3alfisc s3alfisc commented Aug 30, 2024 •
edited
Loading

  1. Fix a bug in the resid() and predict() method when models are empty.
  2. Flattens the output of the resid() method.
  3. Always returns raw residuals via the resid method, not weighted residuals (for compatibility with fixest).
  4. Fixes bug in predict() method for WLS.

See #596 for details.

@s3alfisc s3alfisc linked an issue Aug 30, 2024 that may be closed by this pull request
Unexpected behavior with resids and predict post feols #596
Closed
@s3alfisc s3alfisc merged commit 05f44bd into master Aug 31, 2024
6 of 7 checks passed
@s3alfisc s3alfisc deleted the fix-empty-resid branch August 31, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior with resids and predict post feols
1 participant
@s3alfisc