test run example notebooks #613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
scripts/run_notebooks.py
Outdated
| DOCS / "marginaleffects.ipynb", | ||
| DOCS / "quickstart.ipynb", | ||
| DOCS / "replicating-the-effect.ipynb", | ||
| DOCS / "stargazer.ipynb", # failing notebook |
There was a problem hiding this comment.
@s3alfisc in Cell[22] there is an error in the notebook (checked locally)
NotImplementedError: <class 'pyfixest.estimation.feols_.Feols'>See https://github.com/py-econometrics/pyfixest/actions/runs/10707033524/job/29686144381
| KERNEL_NAME: str = "python3" | ||
| DOCS = Path("docs") | ||
| NOTEBOOKS: list[Path] = [ | ||
| # DOCS / "compare-fixest-pyfixest.ipynb", # needs R |
There was a problem hiding this comment.
Let me work on this notebook on a different PR as it requires some investigation.
There was a problem hiding this comment.
The error likely stems from the fact that Stargazer's default does not have pyfixest support - makes sense to handle this in another pr!
|
@s3alfisc this is ready for review. This set up the tests. I commented two notebooks:
|
|
ok! so any suggested changes or are we good to go @s3alfisc ? :) |
There was a problem hiding this comment.
Looks good to me, will merge now. Sorry that I did not finish the PR review yesterday, I got interrupted and then did not manage to get back to it. Btw I think you are successfully installing R via r2u, so the notebook depending on rpy2/fixest should execute properly =) thank you!
Closes #606