Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split and fsplit arguments to feols and fepois #656

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Add split and fsplit arguments to feols and fepois #656

merged 5 commits into from
Oct 16, 2024

Conversation

s3alfisc
Copy link
Member

Add split and fsplit argument to feols and fepois.

So far, it is only supported to look through all categories of a split or fsplit value. Addresses #10 .

After merging this PR, we can easily loop over multiple samples by running

%load_ext autoreload
%autoreload 2

import pyfixest as pf

data = pf.get_data()

fit = pf.feols(
    fml = "Y ~ X1 + csw(f3, X2)", 
    data = data, 
    fsplit = "f1"
)

pf.etable(fit)

@s3alfisc s3alfisc mentioned this pull request Oct 16, 2024
3 tasks
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/estimation/FixestMulti_.py 93.22% 4 Missing ⚠️
pyfixest/report/summarize.py 33.33% 2 Missing ⚠️
pyfixest/estimation/feols_.py 87.50% 1 Missing ⚠️
pyfixest/report/visualize.py 50.00% 1 Missing ⚠️
Flag Coverage Δ
core-tests 77.43% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/errors/__init__.py 100.00% <ø> (ø)
pyfixest/estimation/FormulaParser.py 96.50% <100.00%> (+0.10%) ⬆️
pyfixest/estimation/estimation.py 95.65% <100.00%> (+0.53%) ⬆️
pyfixest/estimation/feiv_.py 98.16% <ø> (ø)
pyfixest/estimation/feols_compressed_.py 83.33% <ø> (ø)
pyfixest/estimation/fepois_.py 87.80% <ø> (ø)
pyfixest/estimation/feols_.py 82.92% <87.50%> (+0.02%) ⬆️
pyfixest/report/visualize.py 54.83% <50.00%> (ø)
pyfixest/report/summarize.py 85.97% <33.33%> (-0.33%) ⬇️
pyfixest/estimation/FixestMulti_.py 80.61% <93.22%> (-1.11%) ⬇️

@s3alfisc s3alfisc merged commit d18aba3 into master Oct 16, 2024
9 checks passed
@s3alfisc s3alfisc deleted the fsplit branch October 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant