Multiple Functions require lists of Feols/Feiv/Fepois object; reject FixestMulti #693 #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert FixestMulti to a list so that it works automatically with the following functions: - pf.bonferroni() - pf.rwolf() - pf.coefplot() - pf.iplot()
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Hi @IshwaraHegde97, looks very good already! Could you add small API test to test_multcomp.py? E.g. something like this: def test_multi_vs_list():
seed = 1232
data = pf.get_data()
fit_all = pf.feols("Y + Y2 ~ X1 + X2", data=data)
fit1 = pf.feols("Y ~ X1 + X2", data=data)
fit2 = pf.feols("Y2 ~ X1 + X2", data=data)
assert bonferroni(fit_all, "X1").equals(bonferroni([fit1, fit2], "X1"))
assert rwolf(fit_all, "X1", seed = seed).equals(rwolf([fit1, fit2], "X1", seed = seed)) |
Added a test to compare the results when passing a list of Feols/Feiv/Fepois objects vs. a FixestMulti object to bonferroni and rwolf functions.
pixi.lock file was updated
Minor changes for consistency
handle .coefplot() method for FixestMulti, where models is a dict_values instance.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@all-contributors please add @IshwaraHegde97 for code |
|
I've put up a pull request to add @IshwaraHegde97! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to convert instances of FixestMulti into lists so that it automatically works with the following functions: