Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iplot error lpdid #754

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix iplot error lpdid #754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b841f4
fix error when calling iplot twice
s3alfisc Dec 18, 2024
9e64288
update changelog
s3alfisc Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/changelog.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## PyFixest 0.28.0 (In Development, can be installed from github)

- Fix a bug that caused reindexing of `LPDID._coeftable` when calling `LPDID.iplot()`. As a result, a second call of `LPDID.iplot()` would fail.

## PyFixest 0.27.0

- Adds support for Gelbach's (JoLe 2016) Regression Decomposition method using a `decompose()` method for `Feols`.
Expand Down
2 changes: 1 addition & 1 deletion pyfixest/did/lpdid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def iplot(
lets-plot figure
A lets-plot figure with coefficient estimates and confidence intervals.
"""
df = self._coeftable
df = self._coeftable.copy()
df["fml"] = "lpdid"

return _coefplot(
Expand Down
Loading