{nb} text shaping breakage can't be worked around anymore

[philj56]

Related to #1090:

In fpdf2 2.7.7, it was possible to work around text shaping breaking {nb} by temporarily disabling it (as is done in the example in #1090). From 2.7.8 onwards, this is no longer possible; enabling text shaping once breaks all subsequent {nb}s, even if it is disabled again.

Minimal example:

from fpdf import FPDF

pdf = FPDF()
pdf.add_font('mulish', style='', fname='mulish-regular.ttf')
pdf.add_page()
pdf.set_font('mulish', '', 24)
pdf.write(text='Pages {nb}')
pdf.ln()
pdf.set_text_shaping(True)
pdf.write(text='Pages {nb}')
pdf.ln()
pdf.set_text_shaping(False)
pdf.write(text='Pages {nb}')
pdf.output('test.pdf')

With fpdf2 2.7.7:

With fpdf2 2.7.8+:

[Lucas-C]

Hi @philj56

Thank you for the report.

This is in fact a known limitation:

• https://py-pdf.github.io/fpdf2/TextShaping.html
• https://py-pdf.github.io/fpdf2/PageBreaks.html#inserting-the-final-number-of-pages-of-the-document
• {nb} breaks if text shaping is turned on with certain fonts #1090

Maybe the existing issue #1090 is enough to track this?
Do you see extra value in your bug report compared to the information already in #1090? 🙂

[philj56]

Hi @Lucas-C,

It's a known limitation, but you used to still be able to get page numbers to work by temporarily disabling text shaping just for the page number, then re-enabling it. This is no longer possible, so it seems like something else has changed internally and this might be a different issue, something like text shaping not being disabled when expected. (e.g. the example code given in #1090 no longer produces the same output).

I think the information here is useful in addition to that in #1090, but I'm happy for them to be merged / handled however you see fit.

[Lucas-C]

You are right @philj56, the problem is elswewhere.

I think I found the issue & fixed it in PR #1288

@allcontributors please add @philj56 for bug

[allcontributors]

@Lucas-C

I've put up a pull request to add @philj56! 🎉

[philj56]

That's great, thanks for the quick reply and fix!

[Lucas-C]

@philj56 Could you please test if this issue is solved for you using the latest version of fpdf2 from git? 🙂

You can install it with: pip install git+https://github.com/py-pdf/fpdf2.git@master

[philj56]

@Lucas-C Yup, that seems to be working fine now, thanks!

[Lucas-C]

Thank you for testing 👍

[Lucas-C]

This fixup has been included in the new release published today:
https://github.com/py-pdf/fpdf2/releases/tag/2.8.2