-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added basic support for Free Text annotations #1039
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
- Coverage 93.58% 93.57% -0.02%
==========================================
Files 29 29
Lines 8514 8530 +16
Branches 1566 1572 +6
==========================================
+ Hits 7968 7982 +14
- Misses 338 339 +1
- Partials 208 209 +1 ☔ View full report in Codecov by Sentry. |
This is promising!
Have you checked that those Free Text annotations are visible when using a PDF reader? What remains to be done in order for this PR to be complete and that we merge it:
|
Thank you @andersonhc, your review helped me a lot. I implemented the changes in the way as you suggested. Color, font and size can be now set for free text annotations. |
I made a single review comment. @allcontributors please add @MarekT0v for code |
I've put up a pull request to add @MarekT0v! 🎉 |
Merged! Thank you very much for your contribution @MarekT0v 👍 |
#949
Currently it supports basic Free Text annotations.
"Basic"> Meaning, that one can't set annotation's color, font or font size. These are set by default now to black color, Helvetica, 12.
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.