-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for CSS page break properties + bugfixes #1209
Conversation
bf013d7
to
00fc1d9
Compare
If you want to review this @gmischler & @andersonhc, I'll be happy to have your feedbacks 🙂 Else I'll merge this later this week. |
9346116
to
7cc0695
Compare
7cc0695
to
c0dcf20
Compare
c18a26a
to
05f02d4
Compare
ee79ee1
to
8d09425
Compare
0efe4fb
to
e0a5ec2
Compare
@gmischler: would you like to take the time to review this PR more in-depths? |
e0a5ec2
to
7a3d88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't spot any show-stoppers.
…space to be rendered on a page
7a3d88b
to
5c02331
Compare
@Lucas-C the new behaviour of |
Hi @beldaz Thank you for the report. Could you maybe open a dedicated issue about this, and provide a minimal code snippet reproducing the issue, please? This is indeed worrying, and should at least inform users about this in our CHANGELOG.md Are you sure that this is related to |
Hi @Lucas-C yes, will do. Yes, this relates to |
This PR also fixes a bug introduced in PR #1207 regarding
font_size_pt
set in the current graphics state when using.local_context()
.Before merging this PR, this bug is visible on the
master
branch in the following reference files:I did not see this regression in PR #1207 because I misread the positioning of the PDFs in the HTML page produced by
scripts/compare-changed-pdfs.py
: in order to avoid this to happen again, I added an explicit legend at the top of the page, explaining what are the PDFs in the left & right columns.Finally, this PR also fixes automatic page break when an image, inserted through
.write_html()
withoutheight
attribute, does not have enough vertical space to be rendered on a page.Checklist:
The GitHub pipeline is OK (green), meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.