Added TextStyle Horizontal Alignment

[visheshdvivedi]

Added horizontal alignment feature for TextStyle.

Fixes #1282

Checklist:

• A unit test is covering the code added / modified by this PR

• This PR is ready to be merged

• In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

• A mention of the change is present in CHANGELOG.md

I couldn't find any docstring and a dedicated section as documentation for TextStyle. Please message me if it exists, will update it accordingly

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

[andersonhc]

@visheshdvivedi

please remove the "generate=True" from the test below:

Run # Ensuring there is no generate=True left remaining in calls to assert_pdf_equal:
test/outline/test_outline.py: assert_pdf_equal(pdf, HERE / "test_start_section_horizontal_alignment.pdf", tmp_path, generate=True)

[visheshdvivedi]

Hi @andersonhc,

Added commit to remove generate=True

[andersonhc]

Hi @andersonhc,

Added commit to remove generate=True

The test on python 3.9 is failing due to use of pipe to union. That feature was introduced in Python 3.10

Can you replace it by Union so we can keep compatibility with older Python versions?

[visheshdvivedi]

Hi @andersonhc,

Replaced pipe operator with Union as suggested.

[Lucas-C]

Good job overall @visheshdvivedi 👍

The GitHub Actions pipeline is currently failing:

Run black --check .
Skipping .ipynb files as Jupyter dependencies are not installed.
You can fix this by running ``pip install "black[jupyter]"``
would reformat /home/runner/work/fpdf2/fpdf2/test/outline/test_outline.py
would reformat /home/runner/work/fpdf2/fpdf2/fpdf/fpdf.py

Oh no! 💥 💔 💥
2 files would be reformatted, 188 files would be left unchanged.

To solve this, you could either install & setup pre-commit hooks: https://py-pdf.github.io/fpdf2/Development.html#pre-commit-hook
Or just run black on the 2 files mentioned in the log above.

---

Once you'll have rebased your branch on this repo master branch,
you should find this on line 44 in fpdf/html.py:

    "title": TextStyle(  # Only rendered if render_title_tag=True
        b_margin=0.4,
        font_size_pt=30,
        t_margin=6,
        # center=True, - Enable this once #1282 is implemented
    ),

This comes from PR #1298.
Could you replace the commented out center=True line by l_margin=Align.C now that you have implemented this feature, please?

[Lucas-C]

Hi @visheshdvivedi

Just for your information, several occurences of title_style were renamed into text_style in commit 7b3f1bd last week.

I think this caused minor issues in your PR when you rebased your branch:

fpdf/fpdf.py:5153:31: E0602: Undefined variable 'title_style' (undefined-variable)
fpdf/fpdf.py:5169:11: E0602: Undefined variable 'text_style' (undefined-variable)
fpdf/fpdf.py:5169:26: E0602: Undefined variable 'text_style' (undefined-variable)
fpdf/fpdf.py:5170:20: E0602: Undefined variable 'text_style' (undefined-variable)

[Lucas-C]

Hi @visheshdvivedi 🙂

Just to get a quick update: do you still want to implement this feature?

[visheshdvivedi]

Hi @Lucas-C ,

Yes, very much.

Aplogies for the delay on my side, have been occupied for sometime in personal tasks. But I will try to put more time on this and complete it.

[Lucas-C]

Aplogies for the delay on my side, have been occupied for sometime in personal tasks. But I will try to put more time on this and complete it.

No worries 👍

Just please keep us informed if ever you realize that you won't be able to finish this, and the maintainers will take over 🙂

[visheshdvivedi]

Hi @Lucas-C ,

I have completed the code and written the tests, but having issues with passing all tests. Have been stuck here for sometime now. Would you be able to assist ?

Thanks for your support

[andersonhc]

@visheshdvivedi
After some debugging I found out all float l_margin were defaulting to 0 due to the insinstance check.
I rebased your branch and pushed a fix.
Please review and let us know if it's ready or if you have more work to do on this PR.

Thanks

[Lucas-C]

After some debugging I found out all float l_margin were defaulting to 0 due to the insinstance check.
I rebased your branch and pushed a fix.

Thanks a lot @andersonhc, well done!

I added a commit to introduce extra checks when unsupported text_style.l_margin values are provided to .use_text_style() or TableOfContents().

I also added one last commit to support Align values provided as l_margin in HTML tags styles.

I'm going to merge this now in order to include this nice feature in the next release 🙂

Thank you @visheshdvivedi for your contribution 👍

[Lucas-C]

@allcontributors please add @visheshdvivedi for code

[allcontributors]

@Lucas-C

I've put up a pull request to add @visheshdvivedi! 🎉

[visheshdvivedi]

Hi @Lucas-C and @andersonhc,

Thanks you so much for your help and support. This is kinda like my first proper open source contribution and I wouldn't have been able to make it without your help.

If you ever feel like any new feature or bug request is required, please message me I will gladly help with the same.

[Lucas-C]

Thanks you so much for your help and support. This is kinda like my first proper open source contribution and I wouldn't have been able to make it without your help.

You are very welcome 🙂

By the way, your contribution has been included in the new release of fpdf2!
https://github.com/py-pdf/fpdf2/releases/tag/2.8.2