image() method now inserts .svg images as PDF paths

[Lucas-C]

Could I have your review on this please @torque? 😊

[codecov]

Codecov Report

Merging #337 (484f3ef) into master (b1360a3) will increase coverage by 0.39%.
The diff coverage is 91.01%.

❗ Current head 484f3ef differs from pull request most recent head b983b3e. Consider uploading reports for the commit b983b3e to get more accurate results

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   89.99%   90.38%   +0.39%     
==========================================
  Files          19       20       +1     
  Lines        5815     5928     +113     
  Branches     1167     1192      +25     
==========================================
+ Hits         5233     5358     +125     
+ Misses        365      346      -19     
- Partials      217      224       +7     

Impacted Files	Coverage Δ
fpdf/svg.py	97.61% <76.00%> (-0.78%)	⬇️
fpdf/fpdf.py	85.35% <87.50%> (+1.04%)	⬆️
fpdf/line_break.py	99.01% <99.01%> (ø)
fpdf/image_parsing.py	91.66% <100.00%> (-2.46%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1360a3...b983b3e. Read the comment docs.

[torque]

I'll take a look at it this weekend.

[torque]

I looked through the changes and they make sense to me.

I do think it would be better if the image() function were to try to detect whether or not the image is an SVG at a later stage (e.g. by looking at the contents see if it starts with <svg and/or parses as XML, though I don't know what sort of false positive or false negative rate this exact check would have), as the current implementation will only work with SVGs provided by filename, while the function's documentation claims it also accepts URLs and BytesIO objects.

[Lucas-C]

Thank you very much for your feedback @torque !
I added a commit to ensure that a <svg> can be passed as BytesIO to FPDF.image