-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to SVG conversion: defs, shapes and clipping paths #968
Conversation
…work, added additional installs to Development.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
You probably want to remove those "actual.pdf", "actual_qpdf.pdf", and "expected_qpdf.pdf" files. I assume they are left over from your testing experiments?
A few points more to round this up:
Don't worry that some of the test runs failed, that is an annoyance we need to address separately. |
above is done! I also added code for making reference pdfs for testing -- I know it was already mentioned, but I figure putting the code in there explicitly will save someone time down the line |
Alright, one last thing that didn't previously catch my eye: |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 93.63% 93.70% +0.06%
==========================================
Files 28 28
Lines 8248 8276 +28
Branches 1508 1514 +6
==========================================
+ Hits 7723 7755 +32
+ Misses 325 324 -1
+ Partials 200 197 -3
☔ View full report in Codecov by Sentry. |
Thanks for the excellent contribution, @afriedman412 ! Merging it now. |
Thank you for your excellent contribution @afriedman412, |
@allcontributors please add @afriedman412 for code |
I've put up a pull request to add @afriedman412! 🎉 |
Fixes #858
rect
,circle
etc) now work indefs
defs
tags get read first instead of sequentiallySVGs allow you pre-define objects anywhere, which means they can be cross-referenced before they are created. Our code didn't do that, but now it does.
ie fpdf can accurately convert this file now:
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.